Skip to content

docs: add ELI5 video to home page#12379

Merged
SimenB merged 3 commits intojestjs:mainfrom
dmitryvinn-fb:eli5-video-update
Feb 13, 2022
Merged

docs: add ELI5 video to home page#12379
SimenB merged 3 commits intojestjs:mainfrom
dmitryvinn-fb:eli5-video-update

Conversation

@dmitryvinn-fb
Copy link
Copy Markdown
Contributor

@dmitryvinn-fb dmitryvinn-fb commented Feb 13, 2022

Summary

Here at Meta Open Source, we've been creating short-form videos to explain Meta OSS projects in the simplest terms possible. We started embedding these videos into project pages as you can see in Hermes home pageor in Docusaurus home page](https://docusaurus.io/)

Test plan

This is how the video appears on the home page:
image

@dmitryvinn-fb dmitryvinn-fb requested a review from SimenB February 13, 2022 05:13
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 13, 2022

Codecov Report

Merging #12379 (a501c2c) into main (faef0b4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12379   +/-   ##
=======================================
  Coverage   68.47%   68.47%           
=======================================
  Files         324      324           
  Lines       16967    16967           
  Branches     5060     5060           
=======================================
  Hits        11618    11618           
  Misses       5317     5317           
  Partials       32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faef0b4...a501c2c. Read the comment docs.

Biki-das
Biki-das reviewed Feb 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Biki-das Biki-das left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dmitryvinn-fb that's a good one, please run yarn lint:prettier and push again , this should solve the failed lint check.

SimenB
SimenB approved these changes Feb 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@SimenB SimenB merged commit 0543584 into jestjs:main Feb 13, 2022
@dmitryvinn-fb
Copy link
Copy Markdown
Contributor Author

dmitryvinn-fb commented Feb 13, 2022

Thank you all!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 16, 2022

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SimenB SimenB SimenB approved these changes

+1 more reviewer

@Biki-das Biki-das Biki-das left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dmitryvinn-fb @codecov-commenter @SimenB @Biki-das @facebook-github-bot
⚡